Feature/change email #407
Merged
Feature/change email #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2024 01:18
Signed-off-by: Dan Griffiths <[email protected]>
Signed-off-by: Dan Griffiths <[email protected]>
UncleClapton
requested changes
Nov 4, 2024
src/store/actionTypes.js
Outdated
Comment on lines
100
to
102
| const emails = { | ||
| update: 'emails/update', | ||
| } |
There was a problem hiding this comment.
lets move this so it's a sub-group of the user actions named email, since it only pertains to the user's email.
src/store/actions/authentication.js
Outdated
Comment on lines
22
to
32
| export const changeEmail = ({ id, ...data }) => { | ||
| return frApiPlainRequest( | ||
| actionTypes.emails.update, | ||
| { | ||
| url: `/users/${id}/email`, | ||
| method: 'patch', | ||
| data: createRequestBody('email-changes', data), | ||
| }, | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Lets move this to the user actions file.
Signed-off-by: Dan Griffiths <[email protected]>
UncleClapton
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Adds an option to user profiles to change their registered email address.
✨ Additions
Contributor's Checklist
yarn lintand confirmed there are no errors or warnings.CONTRIBUTING.md.Maintainer's Checklist
CHANGELOG.md.